[PATCH] D32835: [compiler-rt] [cmake] Support generic installation

[Catherine Moore via Phabricator via llvm-commits]

clm added inline comments.


================
Comment at: CMakeLists.txt:41
+set(COMPILER_RT_LIBNAME "" CACHE STRING 
+  "Customize the library installation name")
+
----------------
beanz wrote:
> What is the intention for this variable? Other than checking if it is set this doesn't seem to be used at all.
The intention is to allow for a custom library name to be defined when cmake is invoked either by -C <cache_file> or -D options.

By using a combination of  COMPILER_RT_LIBRARY_INSTALL_DIR and COMPILER_RT_LIBNAME, different multilib combinations from the same architecture can be built and differentiated by directory name.

For example:

install/lib/clang-runtimes/arm-none-eabi/v7/libclang_rt.builtins.a
install/lib/clang-runtimes/arm-none-eabi/v8/libclang_rt.builtins.a

etc.





https://reviews.llvm.org/D32835