[PATCH] D32835: [compiler-rt] [cmake] Support generic installation

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: CMakeLists.txt:41
+set(COMPILER_RT_LIBNAME "" CACHE STRING 
+  "Customize the library installation name")
+
----------------
What is the intention for this variable? Other than checking if it is set this doesn't seem to be used at all.


================
Comment at: cmake/Modules/AddCompilerRT.cmake:141
+    message(STATUS "Setting libname to ${libname}")
+    message(STATUS "COMPILER_RT_OS_SUFFIX is ${COMPILER_RT_OS_SUFFIX}")
+    set(sources_${libname} ${LIB_SOURCES})
----------------
These look like debugging messages that should be removed.


https://reviews.llvm.org/D32835