[PATCH] D32881: Read public symbol names for LazyObjectFiles in parallel.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 16:58:09 PDT 2017


On Thu, May 25, 2017 at 7:51 PM, Davide Italiano via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On Thu, May 25, 2017 at 7:47 PM, Rui Ueyama via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Here is the table of your benchmark results. It seems they aren't
> different
> > to me.
> >
> > --threads
> >
> > Index          w/o Index
> > 3.128589132    3.128069636    1.000
> > 3.302902865    3.294943688    1.002
> > 4.842033728    4.852418117    0.997
> > 5.031806070    5.007721261    1.004
> > 5.061450822    5.067567389    0.998
> > 5.223625773    5.213661213    1.001
> > 2.777111220    2.770632998    1.002
> > 2.870435296    2.876185518    0.998
> > 2.041417779    2.043296975    0.999
> > 2.120939637    2.121668866    0.999
> > 1.543028971    1.551262595    0.994
> > 1.556195605    1.559701231    0.997
> >
> > --no-threads
> >
> > Index          w/o Index
> > 4.648823604    4.634666491    1.003
> > 4.656633102    4.656090134    1.000
> > 7.298663474    7.288234015    1.001
> > 7.310040628    7.303389055    1.000
> > 7.508681533    7.496336533    1.001
> > 7.517153977    7.512991823    1.000
> > 4.089264337    4.097596474    0.997
> > 4.082382992    4.089621870    0.998
> > 2.202735522    2.210372640    0.996
> > 2.205530082    2.216226573    0.995
> > 3.156375368    3.165926995    0.996
> > 3.158119913    3.166431410    0.997
> >
>
> Honestly, the improvements/regressions seem just noise to me. If these
> are numbers patched/unpatched, I'd say this patch is mostly
> performance neutral.
>

IIRC Rafael's setup was using CPU sets to pin to certain cores. Is it
possible that this is preventing Rui's parallelization from fully utilizing
all the cores?
(i.e. testing --threads configuration when pinned to just a single core)

-- Sean Silva


>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170531/590f7a52/attachment.html>


More information about the llvm-commits mailing list