[PATCH] D33691: AMDGPU/LLD: Remove deprecated and unused elf definitions from tests

Zhuravlyov, Konstantin via llvm-commits llvm-commits at lists.llvm.org
Wed May 31 12:55:25 PDT 2017


Wrote new tests from scratch and missed those. I restored original run and check lines.

________________________________
From: Rafael Avila de Espindola <rafael.espindola at gmail.com>
Sent: Tuesday, May 30, 2017 7:45:07 PM
To: reviews+D33691+public+4003d1ebdf69205c at reviews.llvm.org; Konstantin Zhuravlyov via Phabricator; Zhuravlyov, Konstantin; Arsenault, Matthew; Tye, Tony; tstellar at redhat.com
Cc: Liu, Yaxun (Sam); Ding, Wei; llvm-commits at lists.llvm.org; tpr.llvm at botech.co.uk; Stuttard, David
Subject: Re: [PATCH] D33691: AMDGPU/LLD: Remove deprecated and unused elf definitions from tests

Konstantin Zhuravlyov via Phabricator via llvm-commits

> Index: test/ELF/amdgpu-kernels.s
> ===================================================================
> --- test/ELF/amdgpu-kernels.s
> +++ test/ELF/amdgpu-kernels.s
> @@ -1,13 +1,13 @@
> -# RUN: llvm-mc -filetype=obj -triple amdgcn--amdhsa -mcpu=kaveri %s -o %t.o
> -# RUN: ld.lld %t.o -o %t
> -# RUN: llvm-readobj -sections -symbols -program-headers %t | FileCheck %s
> +# RUN: llvm-mc -filetype=obj -triple amdgcn-amd-amdhsa -mcpu=gfx700 %s -o %t.o
> +# RUN: ld.lld -shared %t.o -o %t
> +# RUN: llvm-readobj -sections -symbols %t | FileCheck %s

Any reason the program headers are not tested now?

Do you have to change the triple and the cpu?

Cheers,
Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170531/372e8e76/attachment.html>


More information about the llvm-commits mailing list