<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Arial,Helvetica,sans-serif">
<p><span style="font-family:Calibri,Arial,Helvetica,sans-serif,serif,EmojiFont; font-size:16px">Wrote new tests from scratch and missed those. I restored original run and check lines.</span><br>
</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Rafael Avila de Espindola <rafael.espindola@gmail.com><br>
<b>Sent:</b> Tuesday, May 30, 2017 7:45:07 PM<br>
<b>To:</b> reviews+D33691+public+4003d1ebdf69205c@reviews.llvm.org; Konstantin Zhuravlyov via Phabricator; Zhuravlyov, Konstantin; Arsenault, Matthew; Tye, Tony; tstellar@redhat.com<br>
<b>Cc:</b> Liu, Yaxun (Sam); Ding, Wei; llvm-commits@lists.llvm.org; tpr.llvm@botech.co.uk; Stuttard, David<br>
<b>Subject:</b> Re: [PATCH] D33691: AMDGPU/LLD: Remove deprecated and unused elf definitions from tests</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Konstantin Zhuravlyov via Phabricator via llvm-commits<br>
<br>
> Index: test/ELF/amdgpu-kernels.s<br>
> ===================================================================<br>
> --- test/ELF/amdgpu-kernels.s<br>
> +++ test/ELF/amdgpu-kernels.s<br>
> @@ -1,13 +1,13 @@<br>
> -# RUN: llvm-mc -filetype=obj -triple amdgcn--amdhsa -mcpu=kaveri %s -o %t.o<br>
> -# RUN: ld.lld %t.o -o %t<br>
> -# RUN: llvm-readobj -sections -symbols -program-headers %t | FileCheck %s<br>
> +# RUN: llvm-mc -filetype=obj -triple amdgcn-amd-amdhsa -mcpu=gfx700 %s -o %t.o<br>
> +# RUN: ld.lld -shared %t.o -o %t<br>
> +# RUN: llvm-readobj -sections -symbols %t | FileCheck %s<br>
<br>
Any reason the program headers are not tested now?<br>
<br>
Do you have to change the triple and the cpu?<br>
<br>
Cheers,<br>
Rafael<br>
</div>
</span></font>
</body>
</html>