[PATCH] D33621: Fix for -wrap linker option and LTO, PR 33145

[Dmitry Mikulin via Phabricator via llvm-commits]

dmikulin marked an inline comment as done.
dmikulin added inline comments.


================
Comment at: lld/ELF/SymbolTable.cpp:124
   for (BitcodeFile *F : BitcodeFiles)
-    LTO->add(*F);
+    LTO->add(*F, isRenamed);
 
----------------
pcc wrote:
> If you move the list of renamed symbols to `Config` you can avoid this lambda.
OK, will do.


================
Comment at: lld/ELF/SymbolTable.cpp:192
+  uint8_t Binding = getSymbolBinding(find(Name));
+  RenamedSymbols[Name] = Binding;
+  RenamedSymbols[Name] = Binding;
----------------
pcc wrote:
> You mean `Alias` here, right?
Of course.


================
Comment at: lld/ELF/SymbolTable.h:141
+  // Save renamed symbols and their original pre-LTO bindings.
+  llvm::StringMap<uint8_t> RenamedSymbols;
 };
----------------
davide wrote:
> I'd be more explicit here. e.g. "this is a map from Symbol name to binding" or something like that.
OK


https://reviews.llvm.org/D33621