[PATCH] D33621: Fix for -wrap linker option and LTO, PR 33145

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

I'll wait for your tests before another careful review. Some drive by comments.



================
Comment at: lld/ELF/SymbolTable.cpp:134-136
+  for (StringMap<uint8_t>::iterator i = RenamedSymbols.begin();
+       i != RenamedSymbols.end();
+       i++) {
----------------
Do you need an explicit iterator? Can't you use a `range for` ?


================
Comment at: lld/ELF/SymbolTable.h:141
+  // Save renamed symbols and their original pre-LTO bindings.
+  llvm::StringMap<uint8_t> RenamedSymbols;
 };
----------------
I'd be more explicit here. e.g. "this is a map from Symbol name to binding" or something like that.


https://reviews.llvm.org/D33621