[PATCH] D33656: [PowerPC] Correctly specify the cache line size for Power 7, 8 and 9.

Tony Jiang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 30 18:06:56 PDT 2017


jtony added inline comments.


================
Comment at: test/CodeGen/PowerPC/ppc64-get-cache-line-size.ll:40
+  br i1 %cmp, label %for.body, label %for.cond.cleanup.loopexit
+; CHECK: main
+; CHECK: dcbt
----------------
For the function name, you may want to use CHECK-LABEL, similarly line 44. And I didn't apply this patch and generate the assembly to see, but generally speaking, if there is one instruction immediately follow another, you may want to use the stronger CHECK-NEXT if possible.  Other than that LGTM.


https://reviews.llvm.org/D33656





More information about the llvm-commits mailing list