[PATCH] D33670: Fix crash when processing relocations in .eh_frame

[Rafael Avila de Espindola via llvm-commits]

Alexander Richardson via Phabricator <reviews at reviews.llvm.org> writes:

> grimar wrote:
>> We do not check what llvm-mc produces in tests for LLD I think.
> I only have this line here to make sure that there is a R_MIPS_64 relocation in .eh_frame in case llvm-mc changes. I could also change it to use a YAML testcase but to me the assembly version is easier to understand.

Please don't use YAML.

We normally don't test the .o, but in this case it is probably OK as the
relocation is not explicit (it is from .cfi_*).

Another option, probably a bit better for a linker test, would be to
write the .eh_frame manually if that is possible:

.section        .eh_frame,"aw", at progbits
.word ...
.word ...

In any case, LGTM. I will commit.

Cheers,
Rafael