[PATCH] D33670: Fix crash when processing relocations in .eh_frame

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added inline comments.


================
Comment at: test/ELF/mips64-eh-abs-reloc.s:3
+# RUN: llvm-mc -filetype=obj -triple=mips64-unknown-freebsd %s -o %t.o
+# RUN: llvm-readobj -r %t.o | FileCheck %s -check-prefix OBJ
+
----------------
grimar wrote:
> We do not check what llvm-mc produces in tests for LLD I think.
I only have this line here to make sure that there is a R_MIPS_64 relocation in .eh_frame in case llvm-mc changes. I could also change it to use a YAML testcase but to me the assembly version is easier to understand.


================
Comment at: test/ELF/mips64-eh-abs-reloc.s:13
+# RUN: ld.lld --eh-frame-hdr -Bdynamic -o %t-dynamic.exe %t.o %t-foo.so
+# RUN: llvm-readobj -r %t-dynamic.exe | FileCheck %s -check-prefix NO-RELOCS
+
----------------
grimar wrote:
> Not sure why do you need to check this. Did executable case crash before this patch ?
> Generally I think you just need simplest test that crashed before and do not crash after.
Only shared lib and -pie executable case would crash before, so I've deleted all but those.


https://reviews.llvm.org/D33670