[PATCH] D33650: MachineVerifier: Verify liveins list

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 30 11:22:29 PDT 2017


MatzeB added a comment.

In https://reviews.llvm.org/D33650#767962, @kparzysz wrote:

> I don't think we should be aborting on legal code.  Maybe we should add an option to treat all verifier reports as warnings (i.e. continue the compilation even if issues were reported)?
>
> Also, didn't you want to eventually get rid of the concept of pristine registers?  Doing that would require the opposite---having them as live-ins almost everywhere.  Is this patch meant as a short-term solution?


Well if we remove the concept we remove the verifier check with it, that's easy :)
So far however seeing pristine registers in livein lists was a good smell for bad code.


Repository:
  rL LLVM

https://reviews.llvm.org/D33650





More information about the llvm-commits mailing list