[PATCH] D31851: [PowerPC] Eliminate compares - add handling for logical operations without the use of condition registers

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

couple of inline comments.



================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2570
+// achieved with xor %a, -1).
+SDValue PPCDAGToDAGISel::getLogicOpInGPR(SDValue LogicOp) {
+  assert(isLogicOp(LogicOp.getOpcode()) &&
----------------
Maybe "computeLogicOpInGPR"?


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2701-2703
+  // Extract the value to a CR bit. If this is a bitwise negation, we simply
+  // extract the EQ bit rather than actually negating the bit set. The logic
+  // is rather simple - the EQ bit is set when the input value is zero.
----------------
I think you mean "single bit" rather than "CR bit" at least I'm reading it that way rather than in a cc register right?


Repository:
  rL LLVM

https://reviews.llvm.org/D31851