[PATCH] D33520: Garbage collect dllimported symbols.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 24 15:21:23 PDT 2017


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/test/COFF/dllimport-gc.test:27
     SectionData:     0000000000000000
+    Relocations:
 symbols:
----------------
I think you can remove this line.


================
Comment at: lld/test/COFF/dllimport-gc.test:37
       Length:          8
-      NumberOfRelocations: 0
+      NumberOfRelocations: 2
       NumberOfLinenumbers: 0
----------------
Can this just be `NumberOfRelocations: 0`?


https://reviews.llvm.org/D33520





More information about the llvm-commits mailing list