[PATCH] D33520: Garbage collect dllimported symbols.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/COFF/Writer.cpp:454
+  if (auto *Sym = dyn_cast<DefinedImportThunk>(Def))
+    if (!Sym->WrappedSym->File->Live)
+      return None;
----------------
pcc wrote:
> I guess this means that we are not gc'ing unused thunks any more. But I guess this isn't a regression, so it seems fine to me.
Yes, that is correct. But in practice we are interested only in eliminating dependencies to DLL files and not to each symbol in a DLL, so it should be fine.


https://reviews.llvm.org/D33520