[lld] r303777 - Rewrite badly-formatted switch. NFC.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Wed May 24 10:12:53 PDT 2017
Author: ruiu
Date: Wed May 24 12:12:53 2017
New Revision: 303777
URL: http://llvm.org/viewvc/llvm-project?rev=303777&view=rev
Log:
Rewrite badly-formatted switch. NFC.
Modified:
lld/trunk/COFF/Symbols.cpp
Modified: lld/trunk/COFF/Symbols.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/Symbols.cpp?rev=303777&r1=303776&r2=303777&view=diff
==============================================================================
--- lld/trunk/COFF/Symbols.cpp (original)
+++ lld/trunk/COFF/Symbols.cpp Wed May 24 12:12:53 2017
@@ -61,16 +61,19 @@ COFFSymbolRef DefinedCOFF::getCOFFSymbol
return COFFSymbolRef(reinterpret_cast<const coff_symbol32 *>(Sym));
}
+static Chunk *makeImportThunk(DefinedImportData *S, uint16_t Machine) {
+ if (Machine == AMD64)
+ return make<ImportThunkChunkX64>(S);
+ if (Machine == I386)
+ return make<ImportThunkChunkX86>(S);
+ assert(Machine == ARMNT);
+ return make<ImportThunkChunkARM>(S);
+}
+
DefinedImportThunk::DefinedImportThunk(StringRef Name, DefinedImportData *S,
uint16_t Machine)
- : Defined(DefinedImportThunkKind, Name) {
- switch (Machine) {
- case AMD64: Data = make<ImportThunkChunkX64>(S); return;
- case I386: Data = make<ImportThunkChunkX86>(S); return;
- case ARMNT: Data = make<ImportThunkChunkARM>(S); return;
- default: llvm_unreachable("unknown machine type");
- }
-}
+ : Defined(DefinedImportThunkKind, Name),
+ Data(makeImportThunk(S, Machine)) {}
Defined *Undefined::getWeakAlias() {
// A weak alias may be a weak alias to another symbol, so check recursively.
More information about the llvm-commits
mailing list