[PATCH] D33169: [X86] Adding vpopcntd and vpopcntq instructions

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86InstrInfo.cpp:881
+    { X86::VPOPCNTDZrr,      X86::VPOPCNTDZrm,        TB_NO_REVERSE },
+    { X86::VPOPCNTQZrr,      X86::VPOPCNTQZrm,        TB_NO_REVERSE },
     { X86::VBROADCASTSSZr,   X86::VBROADCASTSSZm,     TB_NO_REVERSE },
----------------
RKSimon wrote:
> Why TB_NO_REVERSE? This is typically only used for instructions where the mem size doesn't match the reg size to prevent out of bounds loads.
These should also be alphabetized with the rest of the instructions in this section.


================
Comment at: lib/Target/X86/X86InstrInfo.cpp:2310
+    { X86::VPOPCNTDZrrkz,     X86::VPOPCNTDZrmkz,       0 },
+    { X86::VPOPCNTQZrrkz,     X86::VPOPCNTQZrmkz,       0 },
     { X86::VBROADCASTSSZrkz,  X86::VBROADCASTSSZmkz,    TB_NO_REVERSE },
----------------
Alphabetize


================
Comment at: lib/Target/X86/X86InstrInfo.cpp:2933
+    { X86::VPOPCNTDZrrk,          X86::VPOPCNTDZrmk,          0 },
+    { X86::VPOPCNTQZrrk,          X86::VPOPCNTQZrmk,          0 },
     { X86::VBROADCASTSSZrk,       X86::VBROADCASTSSZmk,       TB_NO_REVERSE },
----------------
Alphabetize


Repository:
  rL LLVM

https://reviews.llvm.org/D33169