[PATCH] D33169: [X86] Adding vpopcntd and vpopcntq instructions

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

A couple of minors, but I think you're almost there.



================
Comment at: lib/Target/X86/X86InstrAVX512.td:8692
+multiclass avx512_unary_lowering<SDNode OpNode, AVX512VLVectorVTInfo _,
+  Predicate prd> {
+  let Predicates = [prd] in {
----------------
Don't put Predicate on a new line.



================
Comment at: test/CodeGen/X86/avx512vpopcntdq-intrinsics.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512vpopcntdq | FileCheck %s
+
----------------
Probably worth testing on i686-unknown-unknown triple as well.

I know its overlaps mc test coverage but adding --show-mc-encoding would be trivial since the filechecks are auto-generated, we do this on many other intrinsics test files.


Repository:
  rL LLVM

https://reviews.llvm.org/D33169