[PATCH] D32422: LoopVectorizer: let target prefer scalar addressing computations (+ minor improvements in SystemZTTI)

[Elena Demikhovsky via Phabricator via llvm-commits]

delena added inline comments.


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:7308
+      if (PtrDef && TheLoop->contains(PtrDef) &&
+          getWideningDecision(&I, VF) != CM_GatherScatter)
+        AddrDefs.insert(PtrDef);
----------------
At this point you may have "interleave" decision. I assume, you have nothing to do with it.
I'd check getWideningDecision(&I, VF) == CM_Scalarize)


================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:7321
+        if ((InstOp->getParent() == I->getParent()) && !isa<PHINode>(InstOp) &&
+            AddrDefs.insert(InstOp).second == true)
+          Worklist.push_back(InstOp);
----------------
AddrDefs.insert(InstOp).second == true)  -> AddrDefs.count(InstOp)


https://reviews.llvm.org/D32422