[llvm] r303331 - [lib/Object] - Minor API update for llvm::Decompressor.

[David Blaikie via llvm-commits]

I don't know that changing the name was really necessary here - though I'm
open to hearing ideas/opinions.

Most operations on a vector resize them - when they're intended to add
things to it. So I think the "resizeAnd" prefix is unnecessary and should
be removed/reverted.

On Thu, May 18, 2017 at 1:56 AM George Rimar via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> >clang doesn't like this (Linux, x86-64):
> >
> >/opt/clang/bin/clang++   -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_GLOBAL_ISEL
> >-D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
> >-D__STDC_LIMIT_MACROS -Ilib/Object -I../lib/Object -Iinclude
> >I../include -O2 -g -stdlib=libc++ -fPIC -fvisibility-inlines-hidden
> >-Werror=date-time -std=c++11 -Wall -W -Wno-unused-parameter
> >-Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic
> >-Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor
> >-Wdelete-non-virtual-dtor -Wstring-conversion -fcolor-diagnostics
> >-ffunction-sections -fdata-sections -O2 -g  -fPIC   -UNDEBUG
> >-fno-exceptions -fno-rtti -MD -MT
> >lib/Object/CMakeFiles/LLVMObject.dir/Decompressor.cpp.o -MF
> >lib/Object/CMakeFiles/LLVMObject.dir/Decompressor.cpp.o.d -o
> >lib/Object/CMakeFiles/LLVMObject.dir/Decompressor.cpp.o -c
> >/home/abuild/rpmbuild/BUILD/llvm/lib/Object/Decompressor.cpp
> >In file included from
> >/home/abuild/rpmbuild/BUILD/llvm/lib/Object/Decompressor.cpp:10:
> >../include/llvm/Object/Decompressor.h:33:42: error: extra
> >qualification on member 'resizeAndDecompress'
> >  template <class T> Error Decompressor::resizeAndDecompress(T &Out) {
> >                           ~~~~~~~~~~~~~~^
> >1 error generated.
>
> Hi !
>
> I think that is already was fixed in r303334.
> Sorry for breakage !
>
> George.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170522/48a536ff/attachment.html>