<div dir="ltr">I don't know that changing the name was really necessary here - though I'm open to hearing ideas/opinions.<br><br>Most operations on a vector resize them - when they're intended to add things to it. So I think the "resizeAnd" prefix is unnecessary and should be removed/reverted.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, May 18, 2017 at 1:56 AM George Rimar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">>clang doesn't like this (Linux, x86-64):<br>
><br>
>/opt/clang/bin/clang++   -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_GLOBAL_ISEL<br>
>-D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS<br>
>-D__STDC_LIMIT_MACROS -Ilib/Object -I../lib/Object -Iinclude<br>
>I../include -O2 -g -stdlib=libc++ -fPIC -fvisibility-inlines-hidden<br>
>-Werror=date-time -std=c++11 -Wall -W -Wno-unused-parameter<br>
>-Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic<br>
>-Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor<br>
>-Wdelete-non-virtual-dtor -Wstring-conversion -fcolor-diagnostics<br>
>-ffunction-sections -fdata-sections -O2 -g  -fPIC   -UNDEBUG<br>
>-fno-exceptions -fno-rtti -MD -MT<br>
>lib/Object/CMakeFiles/LLVMObject.dir/Decompressor.cpp.o -MF<br>
>lib/Object/CMakeFiles/LLVMObject.dir/Decompressor.cpp.o.d -o<br>
>lib/Object/CMakeFiles/LLVMObject.dir/Decompressor.cpp.o -c<br>
>/home/abuild/rpmbuild/BUILD/llvm/lib/Object/Decompressor.cpp<br>
>In file included from<br>
>/home/abuild/rpmbuild/BUILD/llvm/lib/Object/Decompressor.cpp:10:<br>
>../include/llvm/Object/Decompressor.h:33:42: error: extra<br>
>qualification on member 'resizeAndDecompress'<br>
>  template <class T> Error Decompressor::resizeAndDecompress(T &Out) {<br>
>                           ~~~~~~~~~~~~~~^<br>
>1 error generated.<br>
<br>
Hi !<br>
<br>
I think that is already was fixed in r303334.<br>
Sorry for breakage !<br>
<br>
George.<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>