[llvm] r302416 - [ARM] Clear the constant pool cache on explicit .ltorg directives

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Mon May 22 02:36:44 PDT 2017


Hi Martin,

I've double checked and you're right, PR32825 was fixed by your commit.
Apologies for being overzealous with reverting; I just saw a commit that I
LGTM'd with an open bug against it and no response from the author.

I shall re-apply the two reverted commits and mark PR32825 as resolved.

James

On Mon, 22 May 2017 at 10:26 Martin Storsjö <martin at martin.st> wrote:

> Hi James,
>
> On Mon, 22 May 2017, James Molloy wrote:
>
> > Hi Martin,
> > Apologies, I have reverted this in r303536. I had to revert the
> > underlying r286006, which is what your patch was fixing. r286006 caused
> > PR32825 which wasn't addressed.
>
> In a quick test I did right now, PR32825 seems to have been fixed by my
> fix in r302416 as well. (It's the exact same issue I had, which I fixed in
> r302416 although I never made a PR out of the issue.) So with the current
> trunk prior to your reverts, you could just have closed PR32825 as fixed,
> no?
>
> // Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170522/a4d78e56/attachment.html>


More information about the llvm-commits mailing list