[PATCH] D33059: Create an shared include directory for gtest helper functions

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

In https://reviews.llvm.org/D33059#759730, @zturner wrote:

> In https://reviews.llvm.org/D33059#759727, @chandlerc wrote:
>
> > In https://reviews.llvm.org/D33059#758161, @zturner wrote:
> >
> > > but I'm not sure if sticking our own directory inside of a directory of third party code would be weird.
> >
> >
> > I also think i would be weird. I'd like us to keep it separate.
>
>
> Bear with me here.  Would it be more or less weird to have a directory of the same name but in a different location?
>
> e.g.
>
>   utils
>     googlemock
>       include
>         gmock
>     googletest
>       include
>         gtest
>     Support
>       include
>         gtest
>           Support
>
>
> This way you could still write `#include "gtest/Support/ErrorChecking.h"` but we wouldn't be stepping on third party code.


While I admire your cleverness here, I think a simpler solution would be better. ;]


https://reviews.llvm.org/D33059