[PATCH] D33059: Create an shared include directory for gtest helper functions

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 11:32:30 PDT 2017


zturner added a comment.

In https://reviews.llvm.org/D33059#759727, @chandlerc wrote:

> In https://reviews.llvm.org/D33059#758161, @zturner wrote:
>
> > but I'm not sure if sticking our own directory inside of a directory of third party code would be weird.
>
>
> I also think i would be weird. I'd like us to keep it separate.


Bear with me here.  Would it be more or less weird to have a directory of the same name but in a different location?

e.g.

  utils
    googlemock
      include
        gmock
    googletest
      include
        gtest
    Support
      include
        gtest
          Support

This way you could still write `#include "gtest/Support/ErrorChecking.h"` but we wouldn't be stepping on third party code.


https://reviews.llvm.org/D33059





More information about the llvm-commits mailing list