[PATCH] D33343: Add some tips on how to benchhmark

[Rafael Avila de Espindola via llvm-commits]

Hiroshi Inoue via Phabricator <reviews at reviews.llvm.org> writes:

> inouehrs added inline comments.
>
>
> ================
> Comment at: docs/Benchmarking.rst:47
> +
> +* Disable the SMP pair of the cpus you will use for the benchmark. The
> +  pair of cpu N can be found in
> ----------------
> Do you mean SMT (e.g. HyperThreding in Intel)? If you mean CPUs in the same socket, `core_siblings_list` can be used (but stopping sibling SMT threads is more important.)

Yes, SMT. I will update it, thanks.

> ================
> Comment at: docs/Benchmarking.rst:55
> +
> +* Run the program with::
> +
> ----------------
> Maybe it is nice to mention about `numactl` command in case for benchmarking parallel programs.

I don't know it. Would you mind sending a patch adding it once this one
is in? :-)

> ================
> Comment at: docs/Benchmarking.rst:57
> +
> +    cset shield --exec -- perf stat -r 10 <cmd>
> +
> ----------------
> Simple explanation on the meaning or -r option will be valuable, i.e. -r 10 will increase the execution time 10x.
>

I will add.