[PATCH] D33343: Add some tips on how to benchhmark

[Hiroshi Inoue via Phabricator via llvm-commits]

inouehrs added inline comments.


================
Comment at: docs/Benchmarking.rst:47
+
+* Disable the SMP pair of the cpus you will use for the benchmark. The
+  pair of cpu N can be found in
----------------
Do you mean SMT (e.g. HyperThreding in Intel)? If you mean CPUs in the same socket, `core_siblings_list` can be used (but stopping sibling SMT threads is more important.)


================
Comment at: docs/Benchmarking.rst:55
+
+* Run the program with::
+
----------------
Maybe it is nice to mention about `numactl` command in case for benchmarking parallel programs.


================
Comment at: docs/Benchmarking.rst:57
+
+    cset shield --exec -- perf stat -r 10 <cmd>
+
----------------
Simple explanation on the meaning or -r option will be valuable, i.e. -r 10 will increase the execution time 10x.


https://reviews.llvm.org/D33343