[llvm] r303375 - LLVM_FALLTHROUGH instead of fall-through comment.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 13:29:41 PDT 2017


You need to include llvm/Support/Compiler.h to use LLVM_FALLTHROUGH, but
doing that is probably not preferred because the file is written in a way
that reduces dependency to LLVM.

Since this broke the build, I'm going to revert.

On Thu, May 18, 2017 at 1:01 PM, Galina Kistanova via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: gkistanova
> Date: Thu May 18 15:01:52 2017
> New Revision: 303375
>
> URL: http://llvm.org/viewvc/llvm-project?rev=303375&view=rev
> Log:
> LLVM_FALLTHROUGH instead of fall-through comment.
>
> Modified:
>     llvm/trunk/lib/Demangle/ItaniumDemangle.cpp
>
> Modified: llvm/trunk/lib/Demangle/ItaniumDemangle.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/
> Demangle/ItaniumDemangle.cpp?rev=303375&r1=303374&r2=303375&view=diff
> ============================================================
> ==================
> --- llvm/trunk/lib/Demangle/ItaniumDemangle.cpp (original)
> +++ llvm/trunk/lib/Demangle/ItaniumDemangle.cpp Thu May 18 15:01:52 2017
> @@ -1947,7 +1947,7 @@ static const char *parse_type(const char
>                break;
>              }
>            }
> -        // falls through
> +          LLVM_FALLTHROUGH;
>          default:
>            // must check for builtin-types before class-enum-types to avoid
>            // ambiguities with operator-names
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170518/a8d6a593/attachment.html>


More information about the llvm-commits mailing list