<div dir="ltr">You need to include llvm/Support/Compiler.h to use LLVM_FALLTHROUGH, but doing that is probably not preferred because the file is written in a way that reduces dependency to LLVM.<div><br></div><div>Since this broke the build, I'm going to revert.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 18, 2017 at 1:01 PM, Galina Kistanova via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: gkistanova<br>
Date: Thu May 18 15:01:52 2017<br>
New Revision: 303375<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=303375&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=303375&view=rev</a><br>
Log:<br>
LLVM_FALLTHROUGH instead of fall-through comment.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Demangle/<wbr>ItaniumDemangle.cpp<br>
<br>
Modified: llvm/trunk/lib/Demangle/<wbr>ItaniumDemangle.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Demangle/ItaniumDemangle.cpp?rev=303375&r1=303374&r2=303375&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Demangle/ItaniumDemangle.cpp?<wbr>rev=303375&r1=303374&r2=<wbr>303375&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Demangle/<wbr>ItaniumDemangle.cpp (original)<br>
+++ llvm/trunk/lib/Demangle/<wbr>ItaniumDemangle.cpp Thu May 18 15:01:52 2017<br>
@@ -1947,7 +1947,7 @@ static const char *parse_type(const char<br>
               break;<br>
             }<br>
           }<br>
-        // falls through<br>
+          LLVM_FALLTHROUGH;<br>
         default:<br>
           // must check for builtin-types before class-enum-types to avoid<br>
           // ambiguities with operator-names<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>