[PATCH] D33323: [llvm-pdbdump] Add the ability to merge PDBs

[Bob Haarman via Phabricator via llvm-commits]

inglorion added a comment.

Then again, I don't feel strongly enough about my preference for separate tools to really hold this up. I'm ok with just renaming this to llvm-pdbtool or some such. The code looks fine to me apart from the thing I mentioned inline.



================
Comment at: llvm/tools/llvm-pdbdump/llvm-pdbdump.cpp:1019
+    }
+    mergePdbs();
   }
----------------
The other subcommands take function arguments, instead of accessing the globals. Can we do that here as well?


https://reviews.llvm.org/D33323