[PATCH] D33323: [llvm-pdbdump] Add the ability to merge PDBs

[Bob Haarman via Phabricator via llvm-commits]

inglorion added a comment.

> What would be the advantage of having it be a separate tool?

Partially the usual "less code, so easier to understand, faster to compile, fewer opportunities to create strong coupling".

I also seem to have the opposite problem when figuring out how to do something. Instead of struggling to remember which of the tools I know exist I need to use, I struggle to discover that a tool exists at all (I can create pdbs from YAML?) or struggle to remember what the subcommand is called (ls or autocomplete will tell me what the name of the binary is, but I then need to run it to figure out if a subcommand exists and how it's spelled).

> I kind of like the fact that I don't have to remember which tool to use when I want something, which kind of solves the problem of tools with overlapping responsibilities. For example, I can never remember whether to use llvm-objdump or llvm-readobj.

In this particular example, I suspect that one is inspired by objdump and one is inspired by readobj. Those do indeed largely do the same things, so it's unfortunate that there are two. On the other hand, things like inspecting pdbs and merging pdbs seem pretty distinct to me.

>   Seems to me they should be the same tool. Like "if you want to do something to a PDB, use llvm-pdbdump". That said, I do agree it does more than just dumping now, so perhaps a new name is in order soon. I wouldn't want to mix a change like that in with other changes though.

Agreed that if we're going to rename the tool, that should go in a separate change.


https://reviews.llvm.org/D33323