[PATCH] D24805: [GVNSink] Initial GVNSink prototype

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

Looks all good from my side. But I am not the best person to review IR transformations, so would be good to wait for someone else.



================
Comment at: lib/Transforms/Scalar/GVNSink.cpp:171
+llvm::raw_ostream &operator<<(llvm::raw_ostream &OS,
+                              SinkingInstructionCandidate &C) {
+  OS << "<Candidate Cost=" << C.Cost << " #Blocks=" << C.NumBlocks
----------------
jmolloy wrote:
> MatzeB wrote:
> > could be `const`
> It's not a member function so can't be const.
I meant `const SinkingInstructionCandidate &C` (for `operator<<` which is a few lines below now)


Repository:
  rL LLVM

https://reviews.llvm.org/D24805