[PATCH] D24805: [GVNSink] Initial GVNSink prototype

[James Molloy via Phabricator via llvm-commits]

jmolloy added a reviewer: eli.friedman.
jmolloy added inline comments.


================
Comment at: lib/Transforms/Scalar/GVNSink.cpp:171
+llvm::raw_ostream &operator<<(llvm::raw_ostream &OS,
+                              SinkingInstructionCandidate &C) {
+  OS << "<Candidate Cost=" << C.Cost << " #Blocks=" << C.NumBlocks
----------------
MatzeB wrote:
> could be `const`
It's not a member function so can't be const.


================
Comment at: lib/Transforms/Scalar/GVNSink.cpp:250
+};
+typedef std::unordered_set<ModelledPHI, /*Hash=*/ModelledPHI> ModelledPHISet;
+
----------------
MatzeB wrote:
> Is there anything missing in llvms `DenseSet` or any other reason for `std::unordered_set`?
> 
Nope, I hadn't even considered DenseSet. I've swapped over.


Repository:
  rL LLVM

https://reviews.llvm.org/D24805