[PATCH] D33059: Create an shared include directory for gtest helper functions

[Zachary Turner via Phabricator via llvm-commits]

zturner updated this revision to Diff 99387.
zturner added a comment.
Herald added a subscriber: mgorny.

Moved the folder.  I really would like to put it in `utils\unittest\googletest\include\gtest\Support`, because then you could write

  #include "gtest/gtest.h"
  #include "gtest/Support/ErrorChecking.h"

but I'm not sure if sticking our own directory inside of a directory of third party code would be weird.

I plan to look into googlemock more in depth in the coming days, and I'll probably start writing a few common matchers (including replacing these macros) along with that effort.  But since this code is already here, I might as well get it in first and do that as an incremental improvement.


https://reviews.llvm.org/D33059

Files:
  llvm/cmake/modules/AddLLVM.cmake
  llvm/unittests/DebugInfo/CodeView/ErrorChecking.h
  llvm/unittests/DebugInfo/CodeView/RandomAccessVisitorTest.cpp
  llvm/unittests/DebugInfo/PDB/ErrorChecking.h
  llvm/unittests/DebugInfo/PDB/HashTableTest.cpp
  llvm/unittests/DebugInfo/PDB/MSFBuilderTest.cpp
  llvm/unittests/DebugInfo/PDB/MappedBlockStreamTest.cpp
  llvm/unittests/DebugInfo/PDB/StringTableBuilderTest.cpp
  llvm/unittests/DebugInfo/PDB/TypeServerHandlerTest.cpp
  llvm/unittests/Support/BinaryStreamTest.cpp
  llvm/utils/unittest/gtestutil/include/gtestutil/ErrorChecking.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33059.99387.patch
Type: text/x-patch
Size: 12384 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170518/c24ed9c9/attachment.bin>