[PATCH] D33059: Create an shared include directory for gtest helper functions

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 17:01:04 PDT 2017


chandlerc added inline comments.


================
Comment at: llvm/include/llvm/gtest/ErrorChecking.h:37
+
+#define EXPECT_EXPECTED(Exp)                                                   \
+  {                                                                            \
----------------
I'm fine moving the existing helpers, but before we expand this, i'd like to think about whether its time to write up the doc about good usage of gmock matchers, get folks OK with that, and write this as a library of matchers that work with EXPECT_THAT instead.


https://reviews.llvm.org/D33059





More information about the llvm-commits mailing list