[PATCH] D33237: [GSoC] Shell autocompletion for clang

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 12:43:51 PDT 2017


ruiu added a comment.

If you are adding code to handle dynamic arguments, then yes, we probably need to define what is the first incremental step towards the goal after discussing how to handle dynamic arguments. But this patch seems somewhat orthogonal to that, no? This doesn't do anything about dynamic arguments and makes sense without a follow-up patch. It adds only 12 lines of code to OptTable.cpp, so "completely revising" it shouldn't be a big deal at all. So I believe this is something we usually submit incrementally.


https://reviews.llvm.org/D33237





More information about the llvm-commits mailing list