[PATCH] D33237: [GSoC] Shell autocompletion for clang

Raphael Isemann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 11:49:09 PDT 2017


teemperor added a comment.

Because the small follow up patch is relevant for the review of this one. If people disagree with the plan there to extend Options.td or OptTable for this feature (and due to the limitations of Options.td in regards to dynamic arguments, this is already controversial), then we have to completely revisit this code which assumes we can do everything in OptTable. I fully agree with incremental development in tree, but for those first two patches I don't see "consensus on the end goal to define the first increment" yet (to quote the LLVM dev policy on this). Sorry, I should have mentioned this fact in the previous mail, but typing on the smartphone is cumbersome.


https://reviews.llvm.org/D33237





More information about the llvm-commits mailing list