[PATCH] D33247: [InstCombine] add isCanonicalPredicate() helper function and use it; NFCI

[Davide Italiano via Phabricator via llvm-commits]

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D33247#756647, @spatel wrote:

> Patch updated:
>  Although this patch is NFCI, we had exactly zero tests for the FCMP transforms, and the ICMP transforms were not tested completely. Given the lumpy handling of the predicates, I think it's best to check all of them to make sure we're doing exactly what we think we're doing.
>
> I checked that there is no difference for the tests before/after this code change, but I can check in the tests first if that would be preferred.


I think adding these tests is a good thing. I don't think it's worth checking in them separately.
I guess this is fine, but please wait for either Eli or David to give another look.


https://reviews.llvm.org/D33247