[PATCH] D33247: [InstCombine] add isCanonicalPredicate() helper function and use it; NFCI

[Sanjay Patel via Phabricator via llvm-commits]

spatel updated this revision to Diff 99192.
spatel added a comment.

Patch updated:
Although this patch is NFCI, we had exactly zero tests for the FCMP transforms, and the ICMP transforms were not tested completely. Given the lumpy handling of the predicates, I think it's best to check all of them to make sure we're doing exactly what we think we're doing.

I checked that there is no difference for the tests before/after this code change, but I can check in the tests first if that would be preferred.


https://reviews.llvm.org/D33247

Files:
  lib/Transforms/InstCombine/InstCombineInternal.h
  lib/Transforms/InstCombine/InstructionCombining.cpp
  test/Transforms/InstCombine/canonicalize_branch.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33247.99192.patch
Type: text/x-patch
Size: 15736 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170516/b7166e7c/attachment.bin>