[llvm] r303133 - [InstCombine] add tests for PR32791; NFC

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 17:37:23 PDT 2017


On Mon, May 15, 2017 at 5:32 PM, Sanjay Patel <spatel at rotateright.com> wrote:
> This is just documenting the current status. If we choose not to transform
> these in InstCombine, then we should have a record of that limitation that
> we acknowledge is a good thing. This way someone won't come along in the
> future and wonder if the transform doesn't exist intentionally or it's just
> an oversight. I can add some test comments once we have a conclusion in
> D33172.
>

Putting these tests in `InstCombine` if we decide to do the
transformation somewhere else is just ... odd.
I don't think we should document all the transformations we don't do
otherwise we will end up with a bunch of useless and/or redundant
tests in tree. Please revert this change until we have reached a
consensus.

--
Davide


More information about the llvm-commits mailing list