[PATCH] D33169: [X86] Adding vpopcntd and vpopcntq instructions

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: test/CodeGen/X86/avx512vpopcntdq-intrinsics.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-apple-darwin -mattr=+avx512vpopcntdq | FileCheck %s
+
----------------
craig.topper wrote:
> RKSimon wrote:
> > Add  --show-mc-encoding ?
> But should we even have this test file or just use the the popcount tests since these aren't x86 specific intrinsics anymore?
Nevermind I guess we need this for mask testing? I assume the generic test doesn't cover it.


Repository:
  rL LLVM

https://reviews.llvm.org/D33169