[PATCH] D33169: [X86] Adding vpopcntd and vpopcntq instructions

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

>> In https://reviews.llvm.org/D33169#754377, @RKSimon wrote:
>> 
>>> Disassembler tests?
>> 
>> 
>> I believe that the test test/MC/X86/x86-64-avx512vpopcntdq.s covers the required tests. 
>>  If you think additional tests are required i will appreciate an example.
> 
> I don't think the MC tests actually use the disassembler code to try and get back to the instruction - @craig.topper can you confirm?

Yeah the .s MC tests don't check the disassembler. That will have to be done from something like test/MC/Disassembler/X86/avx-512.txt



================
Comment at: test/CodeGen/X86/avx512vpopcntdq-intrinsics.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-apple-darwin -mattr=+avx512vpopcntdq | FileCheck %s
+
----------------
RKSimon wrote:
> Add  --show-mc-encoding ?
But should we even have this test file or just use the the popcount tests since these aren't x86 specific intrinsics anymore?


Repository:
  rL LLVM

https://reviews.llvm.org/D33169