[PATCH] D32689: DEF: migrate def parser from LLD to LLVM

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 12:42:34 PDT 2017


ruiu added a comment.

LGTM, but I wonder if someone else wants to see this patch. This is code that I wrote, and Martell is moving it to LLVM, so it's great if we can get 3rd party's review.



================
Comment at: include/llvm/Object/COFFImportFile.h:84
+  bool isWeak() {
+    return (ExtName.size() && Name != ExtName);
+  }
----------------
Remove unnecessary ().


Repository:
  rL LLVM

https://reviews.llvm.org/D32689





More information about the llvm-commits mailing list