[PATCH] D33105: [AMDGPU] Turn register pressure estimation into forward tracker

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In https://reviews.llvm.org/D33105#755202, @rampitec wrote:

> In https://reviews.llvm.org/D33105#755187, @vpykhtin wrote:
>
> > I would not introduce interface in a hope of such usage. This is really counterintuitive. Lets do the RP diff function instead when we need it.
>
>
> OK, think about https://reviews.llvm.org/D33117, GCNSchedStrategy.cpp near line 491. To implement this in the proposed interface I will need to check for the end of the basic block in the advanceBefore(), get the successor, check that is the only successor... I'm really trying to make it faster now ;)


... and then if there is no single successor I would need to return a failure, turning advance to bool and checking it everywhere... Plus pass it a flag if it needs to cross BB boundary or not. Err, that will be a bad interface.


Repository:
  rL LLVM

https://reviews.llvm.org/D33105