[PATCH] D33105: [AMDGPU] Turn register pressure estimation into forward tracker

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In https://reviews.llvm.org/D33105#755187, @vpykhtin wrote:

> In https://reviews.llvm.org/D33105#755186, @rampitec wrote:
>
> > In https://reviews.llvm.org/D33105#755182, @vpykhtin wrote:
> >
> > > This looks a bit as using carkeys to open a bottle. Should we have single instruction RP diff returning function without changing any state?
> >
> >
> > We probably should, but it probably does not belong to this change.
>
>
> I would not introduce interface in a hope of such usage. This is really counterintuitive. Lets do the RP diff function instead when we need it.


OK, think about https://reviews.llvm.org/D33117, GCNSchedStrategy.cpp near line 491. To implement this in the proposed interface I will need to check for the end of the basic block in the advanceBefore(), get the successor, check that is the only successor... I'm really trying to make it faster now ;)


Repository:
  rL LLVM

https://reviews.llvm.org/D33105