[PATCH] D33172: [InstCombine] Simpify inverted predicates in 'or'

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 14 21:37:19 PDT 2017


davide added subscribers: majnemer, davide.
davide added a comment.

I starred a bit at this patch, and I think it's correct.
OTOH, I have feeling of perplexity that arises from the way we're looking at this.
In particular, it seems like we're widening the peephole a little too much -> `or (select (cmp`. 
I'm fairly sure we do the same in other places in InstCombine, so there's a precedent.
I don't have a strong opinion on this, but I'd like if @majnemer or @efriedma could take a look.


https://reviews.llvm.org/D33172





More information about the llvm-commits mailing list