[PATCH] D33155: [DWARFv5] Support FORM_strp in the line table header

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFFormValue.cpp:68
+/// The API follows the equivalent DWARFUnit method names.
+class DWARFFVUnit {
+  const DWARFUnit *U;
----------------
I found the FV a bit hard to parse... DWARFUnitProxy, maybe?


================
Comment at: lib/DebugInfo/DWARF/DWARFFormValue.cpp:122
+  const RelocAddrMap *getRelocMap() const { return RM; }
+  DataExtractor getStringExtractor() const {
+    if (U)
----------------
Are these methods used anywhere? (Or will that come later?)


https://reviews.llvm.org/D33155