[PATCH] D33155: [DWARFv5] Support FORM_strp in the line table header

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 16:37:40 PDT 2017


probinson added a comment.

It turns out that the dumper doesn't visibly distinguish between in-line strings and referenced strings when it dumps the V5 line-table header.  I think I can get that, but it should be a separate follow-up.

I am also thinking that in another follow-up, in DWARFDebugLine.cpp the static helpers to parse the different headers should become private methods.  Then they can lose about half their parameters because they are class data members.

Let me know if you think these are bad ideas.


https://reviews.llvm.org/D33155





More information about the llvm-commits mailing list