[PATCH] D33124: [ELF] - Detemplate GnuHashTableSection and SymbolTableSection sections.

[George Rimar via llvm-commits]

>> Index: ELF/Writer.cpp
>> ===================================================================
>> --- ELF/Writer.cpp
>> +++ ELF/Writer.cpp
>> @@ -335,7 +335,7 @@
>>
>>    if (Config->Strip != StripPolicy::All) {
>>      InX::StrTab = make<StringTableSection>(".strtab", false);
>> -    In<ELFT>::SymTab = make<SymbolTableSection<ELFT>>(*InX::StrTab);
>> +    InX::SymTab = make<SymbolTableSection<ELFT>>(*InX::StrTab);
>>    }
>>
>>    if (Config->BuildId != BuildIdKind::None) {
>> @@ -384,7 +384,7 @@
>>      Add(In<ELFT>::VerNeed);
>>
>>      if (Config->GnuHash) {
>> -      In<ELFT>::GnuHashTab = make<GnuHashTableSection<ELFT>>();
>> +      In<ELFT>::GnuHashTab = make<GnuHashTableSection>();>
>
>Please be consistent. Either replace all the In<ELF>:: with InX:: that
>this change allows or do it all in a followup patch.
>
>Cheers,
>Rafael

I would replace all the In<ELF>:: with InX:: that this change allows to do in a followup patch,
because it looks there are really many places that still use <ELFT> for accessing GnuHashTab, SymTab, DynSymTab
after this one.

I'll replace In<ELFT>::GnuHashTab with  InX::GnuHashTab here to be constent too before commit.
Is it ok to commit with all above ?

George.