[PATCH] D33124: [ELF] - Detemplate GnuHashTableSection and SymbolTableSection sections.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Fri May 12 08:31:49 PDT 2017
George Rimar via Phabricator <reviews at reviews.llvm.org> writes:
> Index: ELF/Writer.cpp
> ===================================================================
> --- ELF/Writer.cpp
> +++ ELF/Writer.cpp
> @@ -335,7 +335,7 @@
>
> if (Config->Strip != StripPolicy::All) {
> InX::StrTab = make<StringTableSection>(".strtab", false);
> - In<ELFT>::SymTab = make<SymbolTableSection<ELFT>>(*InX::StrTab);
> + InX::SymTab = make<SymbolTableSection<ELFT>>(*InX::StrTab);
> }
>
> if (Config->BuildId != BuildIdKind::None) {
> @@ -384,7 +384,7 @@
> Add(In<ELFT>::VerNeed);
>
> if (Config->GnuHash) {
> - In<ELFT>::GnuHashTab = make<GnuHashTableSection<ELFT>>();
> + In<ELFT>::GnuHashTab = make<GnuHashTableSection>();
Please be consistent. Either replace all the In<ELF>:: with InX:: that
this change allows or do it all in a followup patch.
Cheers,
Rafael
More information about the llvm-commits
mailing list