[lld] r302881 - [ELF] - Don't allow R_X86_64_TPOFF32 dynamic relocation when linking PIC

[George Rimar via llvm-commits]

Author: grimar
Date: Fri May 12 02:19:11 2017
New Revision: 302881

URL: http://llvm.org/viewvc/llvm-project?rev=302881&view=rev
Log:
[ELF] - Don't allow R_X86_64_TPOFF32 dynamic relocation when linking PIC

Both gold and bfd restrict that one:

ld.bfd: test.o: relocation R_X86_64_TPOFF32 against `var' can not be 
used when making a shared object; recompile with -fPIC
ld.gold: error: test.o: unsupported reloc 23 against global symbol var

What looks reasonable because it is 32 bit one. Patch do the same.

Differential revision: https://reviews.llvm.org/D33100

Added:
    lld/trunk/test/ELF/x86-64-reloc-tpoff32-fpic.s
Modified:
    lld/trunk/ELF/Target.cpp

Modified: lld/trunk/ELF/Target.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=302881&r1=302880&r2=302881&view=diff
==============================================================================
--- lld/trunk/ELF/Target.cpp (original)
+++ lld/trunk/ELF/Target.cpp Fri May 12 02:19:11 2017
@@ -760,7 +760,8 @@ void X86_64TargetInfo<ELFT>::writePlt(ui
 
 template <class ELFT>
 bool X86_64TargetInfo<ELFT>::isPicRel(uint32_t Type) const {
-  return Type != R_X86_64_PC32 && Type != R_X86_64_32;
+  return Type != R_X86_64_PC32 && Type != R_X86_64_32 &&
+         Type != R_X86_64_TPOFF32;
 }
 
 template <class ELFT>

Added: lld/trunk/test/ELF/x86-64-reloc-tpoff32-fpic.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/x86-64-reloc-tpoff32-fpic.s?rev=302881&view=auto
==============================================================================
--- lld/trunk/test/ELF/x86-64-reloc-tpoff32-fpic.s (added)
+++ lld/trunk/test/ELF/x86-64-reloc-tpoff32-fpic.s Fri May 12 02:19:11 2017
@@ -0,0 +1,14 @@
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+# RUN: not ld.lld %t.o -shared -o %t.so 2>&1 | FileCheck %s
+
+# CHECK: relocation R_X86_64_TPOFF32 cannot be used against shared object; recompile with -fPIC
+# CHECK: >>> defined in {{.*}}.o
+# CHECK: >>> referenced by {{.*}}.o:(.tdata+0xC)
+
+.section ".tdata", "awT", @progbits
+.globl var
+var:
+
+movq %fs:0, %rax
+leaq var at TPOFF(%rax),%rax