[PATCH] D33007: [scudo] Use our own combined allocator

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 14:42:25 PDT 2017


cryptoad marked an inline comment as done.
cryptoad added inline comments.


================
Comment at: lib/scudo/scudo_allocator_combined.h:147
+  void ForEachChunk(ForEachChunkCallback Callback, void *Arg) {
+    UNIMPLEMENTED();
+  }
----------------
alekseyshl wrote:
> Are those UNIMPLEMENTED going to be implemented at some point?
To be perfectly honest, I am not sure.
I think this will mostly depend on needs expressed by the users, but there is no specific timeframe.
For example, they might be a need to walk all the allocator chunks for debugging purposes, which would involve implementing a bunch of them both on the Combined and the Secondary. 


https://reviews.llvm.org/D33007





More information about the llvm-commits mailing list